-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapsible map legend element #2
Comments
Hello, can I try working on this? I can do it! The watermark is from compressing video through a website. 2022-10-24-00-55-04_mp6RvmmD.mp4 |
@sfrunza13 Hello there! Also don't forget to check the live website to know where the rest of the elements are (without having to run the app on locally). The zoom button is at the top left position so your toggle button would overlap, that's why I'm suggesting something like what we find in a FAQ. PS:There are tons of examples/resources in here but I just failed and don't have the time to implement them, it could be helpful for future use anyway (search collapsible or accordion): https://freefrontend.com If you're up for it then fork the project and work on it and I'll assign you to the issue. |
Yes, I'd like to try |
@sfrunza13 I asigned you the issue to work on. PS: |
This is better? test2.mp4 |
@sfrunza13 Looks great! |
@sfrunza13 there are other repos here that are up for hacktoberfest if interested or you can check https://github.com/House-of-M for more. |
Main issue gist
please make a PR to the dev branch where it would be merged if approved.
Implementing a collapsible map legend.
The current branca element based legend is just draggable but not collapsible, it would be great to implement such a feature to minimize the space it takes up on while navigating the map.
Make sure the legend stays draggable when implementing the collapse feature.
map-legend.mp4
Info
The project is using Folium and earthengine-api to generate the map and the raster/vector layers. By default, Folium creates a map in a separate HTML file wildfire-burn-severity/webmap.html from the main python app wildfire-burn-severity/webmap.py .
Even though the project is python based, it generates Leaflet.js based maps through the output html file, the legend is pure HTML/CSS/JS that can be injected in the main python source using Branca library.
I put the branca element based legend in a separate python file wildfire-burn-severity/uilegend.py. You can extract it and treat as just HTML so you get an easier time coding and seeing the results locally as in opposite to running the python app which requires a validated Google Earth Engine account (it takes long time to be accepted and validated).
The css is of course in the src/css
NOTE:
Make sure you put a preview (gif/mp4) of your result in the Pull Request so I can check what it looks like and how it behaves.
The text was updated successfully, but these errors were encountered: