Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration file with comments #18

Merged
merged 19 commits into from
Oct 3, 2023
Merged

Configuration file with comments #18

merged 19 commits into from
Oct 3, 2023

Conversation

hielfx
Copy link
Member

@hielfx hielfx commented Sep 28, 2023

Closes #5

ismaelgonval
ismaelgonval reviewed Oct 2, 2023
View reviewed changes
internal/config/default-config.yml Outdated Show resolved Hide resolved
internal/config/default-config.yml Outdated Show resolved Hide resolved
internal/config/default-config.yml Outdated Show resolved Hide resolved
internal/config/default-config.yml Outdated Show resolved Hide resolved
internal/config/default-config.yml Outdated Show resolved Hide resolved
internal/config/default-config.yml Outdated Show resolved Hide resolved
internal/config/default-config.yml Outdated Show resolved Hide resolved
internal/config/default-config.yml Outdated Show resolved Hide resolved
m4rii0
m4rii0 reviewed Oct 2, 2023
View reviewed changes
internal/config/default-config.yml Outdated Show resolved Hide resolved
internal/config/default-config.yml Outdated Show resolved Hide resolved
internal/config/default-config.yml Outdated Show resolved Hide resolved
@hielfx hielfx marked this pull request as ready for review October 3, 2023 11:00
@hielfx hielfx requested a review from a team as a code owner October 3, 2023 11:00
@hielfx hielfx requested review from m4rii0 and ismaelgonval October 3, 2023 11:03
ismaelgonval
ismaelgonval previously approved these changes Oct 3, 2023
View reviewed changes
m4rii0
m4rii0 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@m4rii0 m4rii0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hielfx hielfx merged commit 2ad125b into main Oct 3, 2023
@hielfx hielfx deleted the feature/GH-5-configuration-file-with-comme branch October 3, 2023 11:58
@hielfx hielfx added the kind/feature Changes implying a new feature for the user label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismaelgonval ismaelgonval ismaelgonval approved these changes

@m4rii0 m4rii0 m4rii0 approved these changes

Assignees
No one assigned
Labels
kind/feature Changes implying a new feature for the user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configuration file with comments
3 participants
@hielfx @m4rii0 @ismaelgonval