Fix for .miso_config / update of package.json #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne from a couple .miso_config inits in pins_arduino.h as compiling failed for XMC11000_XMC2GO due to skipping the not necessary output_level element
LinjingZhang
requested changes
Jul 8, 2024
…DARD" line from a couple .miso_config inits in pins_arduino.h as compiling failed for XMC11000_XMC2GO due to skipping the not necessary output_level element" This reverts commit 7b91618.
LinjingZhang
approved these changes
Jul 9, 2024
jaenrig-ifx
pushed a commit
to jaenrig-ifx/XMC-for-Arduino
that referenced
this pull request
Jan 17, 2025
* - fix package.json for PlatformIO * - removed ".input_hysteresis = XMC_GPIO_INPUT_HYSTERESIS_STANDARD" line from a couple .miso_config inits in pins_arduino.h as compiling failed for XMC11000_XMC2GO due to skipping the not necessary output_level element * Revert "- removed ".input_hysteresis = XMC_GPIO_INPUT_HYSTERESIS_STANDARD" line from a couple .miso_config inits in pins_arduino.h as compiling failed for XMC11000_XMC2GO due to skipping the not necessary output_level element" This reverts commit 7b91618.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
A couple of variants/.../config/.../pins_arduino.h was using this for .miso_config:
.miso_config = {
.mode = XMC_GPIO_MODE_INPUT_TRISTATE,
.input_hysteresis = XMC_GPIO_INPUT_HYSTERESIS_STANDARD
},
And since that skipped .output_level of the struct XMC_GPIO_CONFIG, building for XMC1100_XMC2GO failed with:
"sorry, unimplemented: non-trivial designated initializers not supported."
As the same project built just fine for the XMC4700_Relax_Kit, I compared the files and found this difference.
Adding .output_level for an input pin seems to be wrong and XMC_GPIO_INPUT_HYSTERESIS_STANDARD seems to be the default anyways, so I tried removing that line and it built again.
I also updated package.json from "version": "2.1.0" to "version": "3.1.0" while also adding a couple more lines that are found in the package.json that is installed by PlatformIO.
Ok, 3.1.0 is not really correct, this should be changed to whatever the next release is supposed to be so that it is correct in the release package - but I can not know if the next release will be 3.1.1, 3.2.0 or 4.x or something else entirely.
While this works to use the latest version in PlatformIO:
platform_packages = framework-arduinoxmc @ https://github.com/Infineon/XMC-for-Arduino.git
When listing the dependancies it is listed as framework-arduinoxmc @ 2.1 - but it uses the latest files, so 3.1.0+ actually.
Related Issue
Context
I am using PlatformIO to build my project and it is using arm-none-eabi-g++.
I had to manually convince PlatformIO to use the latest version of XMC-for-Arduino, the platform "Infineon XMC" is still using "framework-arduinoxmc" in version 1.4.0 and this one uses a different pins_arduino.h which does not even have the SPI config.