Fix/release process #289
Merged
Fix/release process #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaenrig-ifx
requested changes
Jul 11, 2024
.github/scripts/release.py
Outdated
|
|
||
| def build_release_assets(version, repository): | ||
| if os.path.exists(pkg_assets_build_path): | ||
| os.system("rm -rf "+pkg_assets_build_path) |
There was a problem hiding this comment.
Why using rm to delete the package?
This will make this script only unix compatible.
There was a problem hiding this comment.
I was testing it in wsl because the runner is also unix...
I can also remove it. This is easy for local test, but is most likely not needed for workflow ( the path is clean
There was a problem hiding this comment.
You don´t need to remove that code, but instead use python apis to remove filesystem folders and files. That way we keep it cross platform.
jaenrig-ifx
approved these changes
Jul 16, 2024
jaenrig-ifx
pushed a commit
to jaenrig-ifx/XMC-for-Arduino
that referenced
this pull request
Jan 17, 2025
Fix/release process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
Fix the release script error
Related Issue
release workflow is not working
Context
release workflow is not working , we have to revert the files in 3.1.0 release.
The problem is in release.py line 76 (old version), where the json arrays are incorrectly combined.