Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final check before XMC1400 BSP/ CAN Lib release #291

Merged
merged 11 commits into from
Aug 5, 2024

Conversation

LinjingZhang
Copy link
Collaborator

@LinjingZhang LinjingZhang commented Jul 23, 2024

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

Description
Details in https://jirard.intra.infineon.com/browse/DESMAKERS-3943
code cleaned , doc updated. example tested.

Related Issue
https://jirard.intra.infineon.com/browse/DESMAKERS-3943

Context
I added the unity structure I had before.
@jaenrig-ifx I changed the release script a bit, so the test files and make files will not be included in release. And make is available for CICD :D

Copy link
Member

@jaenrig-ifx jaenrig-ifx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can document briefly those aspects of the formatting and the tests?
The CAN functional changes I have no judgment criteria. I expect it has been verified in the best way possible (manually).

.clang-format Outdated Show resolved Hide resolved
libraries/CAN/Makefile.test Show resolved Hide resolved
for dir in dirs_to_copy:
shutil.copytree(os.path.join(xmc_ino_root_path, dir), os.path.join(pkg_build_path, dir))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increase the version of the script to 0.2.2?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current version in master is 0.2.0. So 0.2.1 should be correct 🥲 But I don't know why the git log is so strange. We revert this file some times a go....
But in final merge you will see the script is correctly versioned

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if that is the case 👍

@LinjingZhang LinjingZhang merged commit 555e063 into Infineon:feature/can_bus Aug 5, 2024
8 checks passed
jaenrig-ifx pushed a commit to jaenrig-ifx/XMC-for-Arduino that referenced this pull request Jan 17, 2025
Final check before XMC1400 BSP/ CAN Lib release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants