Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: automatically select default port and remove mojibake #298

Conversation

LinjingZhang
Copy link
Collaborator

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

Description
Improve xmc flasher

Related Issue
DESMAKERS3766, DESMAKERS4040

Context

  • If no serial port is selected, pick first jlink device and log the right port
  • Remove mojibake in uploading log

⛔ Synchronizing uploading windows of arduino IDE and the flasher script log as much as possible -> This delay also occurs when using arduino cli. It cannot be improved unless the arduino source code is changed

@LinjingZhang LinjingZhang marked this pull request as ready for review September 3, 2024 17:30
@LinjingZhang
Copy link
Collaborator Author

It would be nice to be able to compile/upload different operating systems in CICD.
That way I wouldn't need to test manually ❤️

@ederjc
Copy link
Member

ederjc commented Sep 6, 2024

Works well for me now!
One more thing, can you add this message after flashing if the right serial port was not selected beforehand:
"Please select port {newSerialport} for using the Serial Monitor or Plotter."
See also: DESMAKERS-3992, point 6.

@LinjingZhang
Copy link
Collaborator Author

Works well for me now! One more thing, can you add this message after flashing if the right serial port was not selected beforehand: "Please select port {newSerialport} for using the Serial Monitor or Plotter." See also: DESMAKERS-3992, point 6.

Done

@jaenrig-ifx
Copy link
Member

If no port is selected, I get this output:
image

Is that the expected behavior?
Other than that it all works very nice :)

@jaenrig-ifx
Copy link
Member

It would be nice to be able to compile/upload different operating systems in CICD. That way I wouldn't need to test manually ❤️

That should be doable from the github actions workflow or?

@LinjingZhang
Copy link
Collaborator Author

It would be nice to be able to compile/upload different operating systems in CICD. That way I wouldn't need to test manually ❤️

That should be doable from the github actions workflow or?

Compiling is fine, but flash is not so easy ...... Though to test xmc-flasher we better be able to flash。
The idea is to run linux in HIL first, windows is usually tested manually, and then once we have a stable HIL we will look at macOS last.

@LinjingZhang
Copy link
Collaborator Author

If no port is selected, I get this output: image

Is that the expected behavior? Other than that it all works very nice :)

I fix it with new commits 😄

@ederjc ederjc force-pushed the feature/DESMAKERS-4040-improve-user-experience-xmc4arduino-flasher-script branch from 26132c1 to c008480 Compare September 9, 2024 15:51
@jaenrig-ifx
Copy link
Member

Working now!

@LinjingZhang LinjingZhang merged commit 52e575c into master Sep 10, 2024
8 checks passed
@ederjc ederjc deleted the feature/DESMAKERS-4040-improve-user-experience-xmc4arduino-flasher-script branch September 25, 2024 13:23
jaenrig-ifx pushed a commit to jaenrig-ifx/XMC-for-Arduino that referenced this pull request Jan 17, 2025
…improve-user-experience-xmc4arduino-flasher-script

Fix: automatically select default port and remove mojibake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants