shakewake: Slightly improve accuracy #1726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build size and comparison to main:
|
|
@FintasticMan What improvement does this PR bring to the user? Or how should we test it? |
|
This change doesn't affect the user much, if at all. It's just a small change that makes the maths closer what was intended according to the comment in the code. |
FintasticMan
force-pushed
the
improve_shakewake_accuracy
branch
from
1e2f58f to
68aa58c
Compare
FintasticMan
force-pushed
the
improve_shakewake_accuracy
branch
from
68aa58c to
0009e03
Compare
This was referenced Jun 17, 2023
The accumulated speed was calculated by dividing first and multiplying after, which results in more rounding errors than if you multiply first and then divide. The values aren't big enough to overflow.
FintasticMan
force-pushed
the
improve_shakewake_accuracy
branch
from
0009e03 to
00a59e8
Compare
|
Merged with #826. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The (accumulated) speed was calculated by dividing first and multiplying/adding after, which results in more rounding errors than if you multiply/add first and then divide. The values aren't big enough to overflow.