Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pulse_gate_circuit support in css #773

Merged
merged 46 commits into from
Dec 20, 2023
Merged

Add pulse_gate_circuit support in css #773

merged 46 commits into from
Dec 20, 2023

Conversation

paaige
Copy link
Contributor

@paaige paaige commented Sep 15, 2023

Closes #768

@@ -154,7 +156,7 @@ def repetitions(self) -> int:
return self._job["shots"]

def compiled_circuit(self) -> cirq.Circuit:
"""Gets the compiled circuit that was submitted for this job.
"""Gets the compiled circuit returned by this job.
Copy link
Contributor Author

@paaige paaige Sep 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for

@paaige
Copy link
Contributor Author

paaige commented Sep 15, 2023

will add a test (currently testing whole flow on a real pulse device)

cirq-superstaq/cirq_superstaq/job.py Outdated Show resolved Hide resolved
cirq-superstaq/cirq_superstaq/job.py Outdated Show resolved Hide resolved
cirq-superstaq/cirq_superstaq/job.py Outdated Show resolved Hide resolved
@paaige paaige requested a review from richrines1 November 6, 2023 20:54
Copy link
Contributor

@richrines1 richrines1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion but otherwise this looks great :)

cirq-superstaq/cirq_superstaq/job.py Outdated Show resolved Hide resolved
@paaige paaige requested a review from richrines1 November 9, 2023 07:03
@richrines1
Copy link
Contributor

(lg % coverage check)

Copy link
Contributor

@richrines1 richrines1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (% typo)!

cirq-superstaq/cirq_superstaq/job.py Outdated Show resolved Hide resolved
@paaige paaige merged commit 89a00d1 into main Dec 20, 2023
16 checks passed
@paaige paaige deleted the pgc_css branch December 20, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have client-superstaq Jobs return pulse_gate_circuits
3 participants