Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a bipartite matching algorithm #192

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

jmlarson1
Copy link
Collaborator

If this graph is always bipartite (which I think is the case) then this matching algorithm should be faster.

Timing for me on the following case:

(n, k): (288, 12)
orders: {x: 12, y: 12}
poly_a: x**2/y**3 + x + 1
poly_b: x**3*y**2 + y + 1

was about 15% faster... so if such a change isn't significant enough, then feel free to close this PR.

@jmlarson1 jmlarson1 requested a review from perlinm as a code owner January 16, 2025 21:32
Copy link
Collaborator

@perlinm perlinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@perlinm perlinm merged commit 8ecf9a6 into reproduce-arxiv Jan 16, 2025
@perlinm perlinm deleted the use_bipartite_matching branch January 16, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants