Qudit class and a newer CSS class #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Started writing the generalized class for qudit codes. Need to run tests and finish this.
Edits for the docstrings based on the checker
factoring out conjugation, shifting, generalizing the definition to other fields
Minor edits to correct trailing whitespaces and the like
Added a test for the random CSS code and the shift method
perlinm
reviewed
Jan 9, 2024
Corrected the matrix shape in the CSSCode_gen class
perlinm
reviewed
Jan 9, 2024
Co-authored-by: Michael A. Perlin <[email protected]>
Incorporated suggestions and modified class methods to instance methods.
Updated the methods to convert between graph and matrix representations in Qudit Code
Added the assert_qubit_code method to help raise such exceptions
mittaltushant
commented
Jan 10, 2024
Updated initialization of the GBCodes to work with newer CSSCode class
Updated QC Codes to work with new CSS class
Replaced CSSCode with the newer version of the class. Removed all the duplicates.
perlinm
reviewed
Jan 10, 2024
perlinm
reviewed
Jan 10, 2024
perlinm
reviewed
Jan 10, 2024
perlinm
reviewed
Jan 10, 2024
perlinm
reviewed
Jan 10, 2024
perlinm
reviewed
Jan 10, 2024
Co-authored-by: Michael A. Perlin <[email protected]>
mittaltushant
commented
Jan 16, 2024
| for identifying the "transpose" a group member p with respect to a representation (lift) L. This | ||
| transpose is defined as the group member p.T for which L(p.T) = L(p).T: if the representation is | ||
| unitary, then p.T is equal to the inverse ~p = p**-1. | ||
| This module only supports representations of group members by orthogonal matrices over finite |
There was a problem hiding this comment.
"orthogonal matrices over finite fields" in abstract.py -- Aren't the lifts always integer-valued permutation matrices?
There was a problem hiding this comment.
Only by default. Users are still free to provide other lifts, and I can imagine adding groups with other lifts in the future. The QuaternionGroup currently in abstract.py is one (perhaps not-too-interesting) example.
qldpc/codes.py
Outdated
| @@ -457,56 +516,55 @@ def get_distance( | |||
| `CSSCode.get_distance_upper_bound` and `CSSCode.get_one_distance_upper_bound`. | |||
|
|
|||
| If `lower is False` and `upper is None`, compute an exact code distance with integer linear | |||
| programming. Warning: this is an exponentially scaling (NP-complete) problem. | |||
| programming. Warning: this is an exponentially difficult(NP-complete) problem. | |||
There was a problem hiding this comment.
Perhaps rephrase it as — "This is an NP-complete problem, and it may take exponential time to execute."
perlinm
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a more general QuditCode class and a modified CSSCode class that factors out the transformation methods (conjugation and shifting), and works over general fields. Some basic tests also added.