Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve folder sorting #1973

Closed
wants to merge 1 commit into from
Closed

Conversation

TommyDL-Infomaniak
Copy link
Contributor

@TommyDL-Infomaniak TommyDL-Infomaniak added enhancement Improve or expand upon an existing feature quick A pull request consisting of a few lines labels Jul 19, 2024
@TommyDL-Infomaniak TommyDL-Infomaniak requested a review from a team July 19, 2024 08:37
@TommyDL-Infomaniak TommyDL-Infomaniak self-assigned this Jul 19, 2024
@github-actions github-actions bot added the dependent This MR depends on another PR label Jul 19, 2024
Copy link

@github-actions github-actions bot removed the dependent This MR depends on another PR label Jul 23, 2024
Copy link

This PR/issue depends on:

Comment on lines +304 to +306
val sortedCustomFolders = customFolders.sortedWith(compareBy { it.name.lowercase().removeAccents() })

customFoldersAdapter.setFolders(sortedCustomFolders, newCurrentFolderId)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will disassociate children from their parents.
We don't want to do that.

@KevinBoulongne KevinBoulongne deleted the imp/folder-sorting branch July 31, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve or expand upon an existing feature quick A pull request consisting of a few lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants