fix: Audio preview #1250
Merged
fix: Audio preview #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrien-coye
force-pushed
the
fix-media-player
branch
2 times, most recently
from
8e0205d to
2a7ae64
Compare
adrien-coye
force-pushed
the
fix-media-player
branch
from
2a7ae64 to
e5b86c9
Compare
PhilippeWeidmann
approved these changes
Aug 9, 2024
…ayer, while the cell only listen to Combine data flow
refactor(MatomoUtils): Moved to core as required by the player, UI stuff kept in an extension in main app
…scrubbing to fix issues with the slider
…previews and it works seamlessly
adrien-coye
force-pushed
the
fix-media-player
branch
from
0ccfc62 to
03c47dd
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
The audio preview cell has a flaky behaviour.
This PR aims at abstracting the "Player" away from the Cell code.
Then I fixed the issue related to the slider.
Note: Moved some of
MatomoUtilsto core in order to use it from the "Single Track Player"Tested on device and mac.