Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(removeFileInDatabase): Fix stack overflow #1260

Merged
merged 2 commits into from
Aug 23, 2024
Merged

fix(removeFileInDatabase): Fix stack overflow #1260

merged 2 commits into from
Aug 23, 2024

Conversation

adrien-coye
Copy link
Contributor

  • Fix infinite recursion

@adrien-coye
fix(removeFileInDatabase): Prevent stack overflow too many recursion,…
f229592 
… no longer using a recursion

fix(removeFileInDatabase): Prevent cyclical folder references to do an infinite loop on deletion
@adrien-coye adrien-coye marked this pull request as ready for review August 23, 2024 10:25
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@adrien-coye adrien-coye merged commit 1d61a9a into master Aug 23, 2024
3 checks passed
@adrien-coye adrien-coye deleted the fix-stackOverflow-too-many-recursions branch August 23, 2024 12:20
adrien-coye added a commit that referenced this pull request Sep 4, 2024
@adrien-coye
fix(DriveFileManager): Deleting a file was broken since 5.0.0-8 by #1260
1b82292
@adrien-coye adrien-coye mentioned this pull request Sep 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeWeidmann PhilippeWeidmann PhilippeWeidmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrien-coye @PhilippeWeidmann