refactor: Rework deeplinks #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…niversalLinksHelper
adrien-coye
changed the base branch from
master
to
externalLinks-famousLastFivePercent
… authentication it is replayed after
adrien-coye
force-pushed
the
externalLinks-rework-deeplinks
branch
from
18f811e to
909c5b7
Compare
8 tasks
…alLinks-rework-deeplinks
|
PhilippeWeidmann
approved these changes
Jan 8, 2025
adrien-coye
merged commit 6f6c012
into
externalLinks-famousLastFivePercent
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PublicSharestruct with failable initPublicSharedeeplink parsing removed from UniversalLinksHelper as it is not sharing the same pattern as other deeplinks.DeeplinkServiceableused to re-trigger deeplinks post authentication.clean install -> public share -> login (or register) -> public shareworks.target pr : #1349