Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Public Share works with app lock #1379

Merged
merged 2 commits into from
Jan 22, 2025
Merged

fix: Public Share works with app lock #1379

merged 2 commits into from
Jan 22, 2025

Conversation

adrien-coye
Copy link
Contributor

@adrien-coye adrien-coye commented Jan 10, 2025 •
edited
Loading

Feature PR #1306

@adrien-coye adrien-coye changed the base branch from master to externalLinks-famousLastFivePercent January 10, 2025 13:17
@adrien-coye adrien-coye mentioned this pull request Jan 10, 2025
Merged
21 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Base automatically changed from externalLinks-famousLastFivePercent to feature-externalLinks January 21, 2025 14:13
@adrien-coye adrien-coye marked this pull request as ready for review January 22, 2025 10:20
@PhilippeWeidmann PhilippeWeidmann merged commit 28d3b98 into feature-externalLinks Jan 22, 2025
5 checks passed
@PhilippeWeidmann PhilippeWeidmann deleted the externalLinks-locking-behaviour branch January 22, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeWeidmann PhilippeWeidmann PhilippeWeidmann approved these changes

Assignees
No one assigned
Labels
public_share
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrien-coye @PhilippeWeidmann