fix(DirectoryEnumerator): Remove deleted items from updated items #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeWeidmann
force-pushed
the
fix-file-provider-enumerator
branch
from
99154bf to
7bcb48d
Compare
Signed-off-by: Philippe Weidmann <[email protected]>
adrien-coye
force-pushed
the
fix-file-provider-enumerator
branch
from
7bcb48d to
56abcbd
Compare
|
adrien-coye
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for KDRIVE-IOS-BWQ
If in the same action result the user has updated and deleted a file (eg. rename then delete). The fileprovider would crash because the updated file was invalidated.
This PR removes the file from the updatedItems if its also in the deletedItems