fix: Invalidated live object crash DiffKit while diffing #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrien-coye
changed the title
|
Did some manual testing, it does fix the issue. I did not encouter a performance issue. |
PhilippeWeidmann
approved these changes
Jan 31, 2025
… with DifferenceKit
adrien-coye
force-pushed
the
fix-invalidated-object-in-uploadFileViewController
branch
from
d57dda3 to
d81c038
Compare
|
adrien-coye
deleted the
fix-invalidated-object-in-uploadFileViewController
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
When cancelling an upload, the app crashes.
DiffKitaccesses an invalidated object and crashes.The
UploadQueueViewControllernow tracks a list of frozen files.The cell was updated to use frozen files as input.
The use of frozen or live file was explicited