Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade tuist + Explicitly declare dependencies #1422

Merged
merged 6 commits into from
Feb 7, 2025
Merged

chore: Upgrade tuist + Explicitly declare dependencies #1422

merged 6 commits into from
Feb 7, 2025

Conversation

PhilippeWeidmann
Copy link
Member

No description provided.

@PhilippeWeidmann PhilippeWeidmann force-pushed the bump-tuist branch 2 times, most recently from bbf1153 to 96788c0 Compare February 7, 2025 08:32
@PhilippeWeidmann PhilippeWeidmann changed the title chore: Upgrade tuist + Correctly declare dependencies chore: Upgrade tuist + Explicitly declare dependencies Feb 7, 2025
@PhilippeWeidmann PhilippeWeidmann force-pushed the bump-tuist branch 3 times, most recently from 5ced948 to 66bf4c1 Compare February 7, 2025 09:41
@PhilippeWeidmann
fix: Remove target grouping
9b80a95 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann
test: Shared Env
59c0bda 
Signed-off-by: Philippe Weidmann <[email protected]>
adrien-coye
adrien-coye reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App runs fine, as well as the share extension.

@PhilippeWeidmann
fix: Lottie needs to be dynamic
f63deea 
Signed-off-by: Philippe Weidmann <[email protected]>
adrien-coye
adrien-coye reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Onboarding works fine 👍

@PhilippeWeidmann
test: Update some old tests
55b0685 
Signed-off-by: Philippe Weidmann <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

adrien-coye
adrien-coye approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is OK, I played with it, tests are passing. Merging it now and updating the open branches whith it.

@adrien-coye adrien-coye merged commit 202c576 into master Feb 7, 2025
6 checks passed
@adrien-coye adrien-coye deleted the bump-tuist branch February 7, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien-coye adrien-coye adrien-coye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilippeWeidmann @adrien-coye