Generate menu url from date month/year

IngoAlbers · Jan 12, 2018 · 3b0b7df · 3b0b7df
1 parent 15ff2bf
commit 3b0b7df
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -16,6 +16,9 @@ Metrics/MethodLength:
 Metrics/AbcSize:
   Max: 20
 
+Metrics/ClassLength:
+  Max: 120
+
 Metrics/BlockLength:
   Max: 40
   Exclude:

diff --git a/app/models/restaurant/lilly_jo.rb b/app/models/restaurant/lilly_jo.rb
@@ -118,7 +118,10 @@ def ensure_current_year(url)
 
     def menu_url(date)
       week = date.strftime('%W')
-      url = "https://lillyjo.ch/wp-content/uploads/2017/12/lilly-jo_wochenmenue_kw-#{week}.pdf"
+      month = date.strftime('%m')
+      year = date.strftime('%Y')
+
+      url = "https://lillyjo.ch/wp-content/uploads/#{year}/#{month}/lilly-jo_wochenmenue_kw-#{week}.pdf"
 
       ensure_current_year(url) ? url : fallback_url(url)
     end

diff --git a/spec/models/restaurant/lilly_jo_spec.rb b/spec/models/restaurant/lilly_jo_spec.rb
@@ -12,17 +12,19 @@
   describe '#get_contents' do
     it 'returns the correct menus for specified day' do
       date = Date.parse('02-08-2017')
-      stub_request(:get, 'https://lillyjo.ch/wp-content/uploads/2017/12/lilly-jo_wochenmenue_kw-31.pdf')
+      stub_request(:get, 'https://lillyjo.ch/wp-content/uploads/2017/08/lilly-jo_wochenmenue_kw-31.pdf')
         .to_return(status: 200, body: file_fixture('lilly-jo_wochenmenue_kw-31.pdf'))
+
+      allow(lilly_jo).to receive(:ensure_current_year).and_return(true)
       expect(lilly_jo.get_contents(date)).to eq [menu1, menu2]
     end
 
     context 'when the default menu is not of current year' do
       it 'returns menus from the fallback url' do
         date = Date.parse('03-10-2017')
-        stub_request(:get, 'https://lillyjo.ch/wp-content/uploads/2017/12/lilly-jo_wochenmenue_kw-40.pdf')
+        stub_request(:get, 'https://lillyjo.ch/wp-content/uploads/2017/10/lilly-jo_wochenmenue_kw-40.pdf')
           .to_return(status: 200, body: file_fixture('lilly-jo_wochenmenue_kw-40.pdf'))
-        stub_request(:get, 'https://lillyjo.ch/wp-content/uploads/2017/12/lilly-jo_wochenmenue_kw-40-1.pdf')
+        stub_request(:get, 'https://lillyjo.ch/wp-content/uploads/2017/10/lilly-jo_wochenmenue_kw-40-1.pdf')
           .to_return(status: 200, body: file_fixture('lilly-jo_wochenmenue_kw-40-1.pdf'))
 
         expect(lilly_jo.get_contents(date)).to eq [menu3, menu4]