LDA Chart and Routine #1797
Merged
LDA Chart and Routine #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
touv
requested changes
Nov 29, 2023
There was a problem hiding this comment.
Je ne crois pas que ce graphiques s'inscrire dans la logique lodex notamment concernant les responsabilités de chaque composant :
- Les formats graphiques affichent un flux de données standards à partir d’une URL et peuvent demander de filtrer ou trier ce résultat.
- Les pré calcul, transforment le jeu de données initial selon un algorithme particulier et créer un (ou plusieurs formats de sortie) et stocke le résultat en base
- Les routines récupèrent les données en base et adaptent éventuellement le résultat au format attendu par les graphiques
Nous pouvons en discuter et échanger sur le design de cette feature
AlasDiablo
added
👷♂️ Ready For Review
JulienMattiussi
approved these changes
Dec 4, 2023
parmentf
requested changes
Dec 5, 2023
| path = value | ||
| value = get('weight') | ||
|
|
||
| [reducing] |
There was a problem hiding this comment.
Maybe you can simplify using [dedupe]
Co-authored-by: François Parmentier <[email protected]>
parmentf
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.