Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update taffy #210

Merged

Conversation

Valentin271
Copy link
Contributor

Updates taffy to the latest crates.io version.

There is no breaking change summary so I had to look in taffy's internal code to figure out which feature went were.

@CosmicHorrorDev CosmicHorrorDev self-requested a review January 8, 2024 18:31
@CosmicHorrorDev
Copy link
Collaborator

Thanks for this! I can take a look after I get off work today

Copy link
Collaborator

@CosmicHorrorDev CosmicHorrorDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be working. Thanks!

The glyphon update will likely be harder since I think there are a few other dependencies that share wgpu as a dependency that may have to be updated together

@CosmicHorrorDev CosmicHorrorDev merged commit 3465294 into Inlyne-Project:main Jan 9, 2024
7 checks passed
@Valentin271 Valentin271 deleted the chore/update-taffy branch January 9, 2024 09:02
@Valentin271
Copy link
Contributor Author

Took a look at it before pushing this PR (I originally wanted to update both in the same PR), it is going to be harder, there are more compiler errors right upfront. expect a PR maybe next week.

@CosmicHorrorDev
Copy link
Collaborator

No rush at all and feel free to open a draft PR if you hit a snag or want some feedback of course!

@CosmicHorrorDev CosmicHorrorDev mentioned this pull request Jan 20, 2024
8 tasks
@nicoburns
Copy link
Contributor

Worth noting that this updates to an older Taffy version rather than a newer one. Which is perfectly reasonable if you want to use the released version. But that's why there's no breaking change notes: the changes haven't been released yet!

@CosmicHorrorDev CosmicHorrorDev added C-refactor Category: Reworking an existing feature A-deps Area: anything and everything to do with dependencies labels Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-deps Area: anything and everything to do with dependencies C-refactor Category: Reworking an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants