Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

评论时,中文输入法未选词时,按 command + enter,会发送评论。中文输入法会停留在选词框。 #410

Closed
5 tasks done
sheben404 opened this issue Jul 28, 2024 · 0 comments

Comments

@sheben404
Copy link
Contributor

Describe the bug

复现步骤:

  1. 在评论框中切换中文输入法,输入英文字符,不要选中词
  2. 按 command + enter
  3. 此时会复现 bug:评论已发送,输入法停留在选词步骤
iShot_2024-07-28_22.58.27.mp4

我准备提一个 pr 修复这个问题

Reproduction

见录屏(原仓库代码未改动复现)

System Info

System:
    OS: macOS 14.5
    CPU: (10) arm64 Apple M1 Pro
    Memory: 171.36 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 16.20.2 - ~/.nvm/versions/node/v16.20.2/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v16.20.2/bin/yarn
    npm: 8.19.4 - ~/.nvm/versions/node/v16.20.2/bin/npm
  Browsers:
    Chrome: 126.0.6478.185
    Edge: 127.0.2651.74
    Safari: 17.5

Used Package Manager

pnpm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.
sheben404 added a commit to sheben404/Shiro that referenced this issue Jul 28, 2024
@Innei Innei closed this as completed in db4a859 Jul 30, 2024
Innei pushed a commit that referenced this issue Aug 29, 2024
* fix: fix #410 && 评论系统中添加每次换行默认换两行

* fix: fix ci error

* fix: 修复 cursorSpan 为 null 的问题

Signed-off-by: Innei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant