Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation control system #52

Merged
merged 3 commits into from
May 3, 2024

Conversation

grillo-delmal
Copy link
Contributor

@grillo-delmal grillo-delmal commented Mar 5, 2024

This PR implements the feature described in #37. The main idea is to enable a system to use puppet animations in inochi-session, either by manual interaction with the UI, or by triggering them using external tracking parameters.

In this video I show how they can be triggered by a keyboard combination using puppetstring and by head motion.

session-animation-demo.webm

Here is the list of the implemented features:

  • Play/Pause/Stop animations
  • Loop control
  • Trigger by tracking
    • Set custom trigger values
    • Control trigger value direction
  • Save/Load animation control config in puppet

Some other things that I thought of that could get implemented too further along the line

  • Trigger by event system
    • Event Queue
    • Implement tracking disconnected/reconnected as Event
    • Move tracking_lost animation to this system.
  • Animation weight
    • Use additive and weight parameters.
    • Evaluate weighed fadein - fadeout options.

I'm still not sure if I want to implement the "Trigger by event" feature considering that currently the only application events I can imagine are "tracking lost" and "reconnect tracking", and those events are already being handled by setting a "tracking_lost" animation.

Its lots of code, so I would appreciate feedback on this feature :)

@grillo-delmal grillo-delmal marked this pull request as draft March 5, 2024 05:34
@grillo-delmal grillo-delmal marked this pull request as ready for review March 5, 2024 13:58
@grillo-delmal grillo-delmal changed the title [Draft] Animation control system Animation control system Mar 5, 2024
@LunaTheFoxgirl LunaTheFoxgirl merged commit bec613a into Inochi2D:v0_8 May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants