Skip to content

Commit

Permalink
COMP: Mark class destructors with override
Browse files Browse the repository at this point in the history
Mark class destructors with `override`.

Fixes:
```
In file included from /Users/builder/externalModules/Filtering/FFT/test/itkComplexToComplex1DFFTImageFilterTest.cxx:27:
[CTest: warning matched] /Users/builder/externalModules/Filtering/FFT/include/itkComplexToComplex1DFFTImageFilter.h:95:11:
warning: '~ComplexToComplex1DFFTImageFilter' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
  virtual ~ComplexToComplex1DFFTImageFilter() {}
          ^
```

and
```
In file included from /Users/builder/externalModules/Filtering/FFT/test/itkFFT1DImageFilterTest.cxx:25:
[CTest: warning matched] /Users/builder/externalModules/Filtering/FFT/include/itkForward1DFFTImageFilter.h:78:11:
warning: '~Forward1DFFTImageFilter' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
  virtual ~Forward1DFFTImageFilter() {}
          ^
```

and
```
In file included from /Users/builder/externalModules/Filtering/FFT/test/itkInverse1DFFTImageFilterTest.cxx:26:
[CTest: warning matched] /Users/builder/externalModules/Filtering/FFT/include/itkInverse1DFFTImageFilter.h:79:11:
warning: '~Inverse1DFFTImageFilter' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
  virtual ~Inverse1DFFTImageFilter() {}
          ^
```

and
```
In file included from /Users/builder/externalModules/Filtering/FFT/test/itkInverse1DFFTImageFilterTest.cxx:26:
In file included from /Users/builder/externalModules/Filtering/FFT/include/itkInverse1DFFTImageFilter.h:102:
In file included from /Users/builder/externalModules/Filtering/FFT/include/itkInverse1DFFTImageFilter.hxx:23:
[CTest: warning matched] /Users/builder/externalModules/Filtering/FFT/include/itkVnlInverse1DFFTImageFilter.h:63:11:
warning: '~VnlInverse1DFFTImageFilter' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
  virtual ~VnlInverse1DFFTImageFilter() {}
          ^
```

raised for example at:
https://open.cdash.org/viewBuildError.php?onlydeltap&buildid=7507381
  • Loading branch information
jhlegarreta committed Oct 12, 2021
1 parent 94dfea4 commit 1daf218
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ class ITK_TEMPLATE_EXPORT ComplexToComplex1DFFTImageFilter : public ImageToImage

protected:
ComplexToComplex1DFFTImageFilter();
virtual ~ComplexToComplex1DFFTImageFilter() {}
~ComplexToComplex1DFFTImageFilter() override{};

void
PrintSelf(std::ostream & os, Indent indent) const override;
Expand Down
2 changes: 1 addition & 1 deletion Modules/Filtering/FFT/include/itkForward1DFFTImageFilter.h
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class ITK_TEMPLATE_EXPORT Forward1DFFTImageFilter : public ImageToImageFilter<TI

protected:
Forward1DFFTImageFilter();
virtual ~Forward1DFFTImageFilter() {}
~Forward1DFFTImageFilter() override{};

void
PrintSelf(std::ostream & os, Indent indent) const override;
Expand Down
2 changes: 1 addition & 1 deletion Modules/Filtering/FFT/include/itkInverse1DFFTImageFilter.h
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ class ITK_TEMPLATE_EXPORT Inverse1DFFTImageFilter : public ImageToImageFilter<TI

protected:
Inverse1DFFTImageFilter();
virtual ~Inverse1DFFTImageFilter() {}
~Inverse1DFFTImageFilter() override{};

void
PrintSelf(std::ostream & os, Indent indent) const override;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class ITK_TEMPLATE_EXPORT VnlInverse1DFFTImageFilter : public Inverse1DFFTImageF
GenerateData() override;

VnlInverse1DFFTImageFilter() {}
virtual ~VnlInverse1DFFTImageFilter() {}
~VnlInverse1DFFTImageFilter() override{};
};

} // end namespace itk
Expand Down

0 comments on commit 1daf218

Please sign in to comment.