Fix doxygen build #3311
Merged
Fix doxygen build #3311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:Documentation
thewtex
reviewed
Mar 18, 2022
As documented in https://cmake.org/cmake/help/v3.16/module/FindDoxygen.html A more robust method for generating a documentation target is provided since cmake version 3.9.
Running doxygen on a single file is not needed as a core part of ITK. Remove the script that needed cmake configure time support and complicated the configuration process.
As documented in https://cmake.org/cmake/help/v3.16/module/FindDoxygen.html A more robust method for generating a documentation target is provided since cmake version 3.9.
hjmjohnson
force-pushed
the
fix-doxygen-build
branch
from
4544308 to
b81f3d7
Compare
Hide unused options when they are not relevant for a build.
|
Failure is unrelated. |
|
/azp run ITK.Linux |
thewtex
approved these changes
Mar 18, 2022
blowekamp
reviewed
Mar 21, 2022
| # -- Only build if 'Documentation' target is requested ALL | ||
| WORKING_DIRECTORY ${ITK_BINARY_DIR}/Utilities/Doxygen | ||
| # -- Some of the ITK_DOXYGEN_INPUT are directories, USE_STAMP_FILE requires only files be listed | ||
| COMMENT "-- Wrapping ITK: Constructing documentation xml structure." |
There was a problem hiding this comment.
@hjmjohnson Thank you for updating to the modern CMake Doxygen support.
I saw this CMake status/comment and had to check to see if I had wrapping enabled for my build, as I found it confusing.
Also I'm in the process of building the Doxygen with XML, because it appears the location changed.
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Mar 8, 2024
The use of doxygen.config has been replaced by DoxygenConfig.cmake, with pull request InsightSoftwareConsortium#3311 commit a96d03f "COMP: Use modern doxygen_add_docs for BUILD_DOCUMENTAITON", Hans Johnson, March 18, 2022
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Mar 12, 2024
nifti2_io.c was removed by: - pull request InsightSoftwareConsortium#2630 commit 68221fd "ENH: Prepare for update to NIFTILIB3.0.1", 9 July 2021 The two doxygen.config.in files were removed by: - pull request InsightSoftwareConsortium#3311 commit a96d03f "COMP: Use modern doxygen_add_docs command ITK_WRAP_DOCS", 11 March 2022 - pull request InsightSoftwareConsortium#4500 commit 0c5c638 "STYLE: Remove doxygen.config.in (superseded by DoxygenConfig.cmake)", 12 March 2024
hjmjohnson
pushed a commit
that referenced
this pull request
Mar 23, 2024
nifti2_io.c was removed by: - pull request #2630 commit 68221fd "ENH: Prepare for update to NIFTILIB3.0.1", 9 July 2021 The two doxygen.config.in files were removed by: - pull request #3311 commit a96d03f "COMP: Use modern doxygen_add_docs command ITK_WRAP_DOCS", 11 March 2022 - pull request #4500 commit 0c5c638 "STYLE: Remove doxygen.config.in (superseded by DoxygenConfig.cmake)", 12 March 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a modern CMake paradigm for building the documentation was the most efficient way to fix a dependency issue related to ITK_WRAP_DOC.
PR Checklist