Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump flake8 version to 3.8.1 #19

Merged
merged 2 commits into from
Jun 12, 2020
Merged

Bump flake8 version to 3.8.1 #19

merged 2 commits into from
Jun 12, 2020

Conversation

josieesh
Copy link
Contributor

@josieesh josieesh commented Jun 12, 2020 •
edited
Loading

  • Adjust the compatibility layer to account for the new flake8 changes here
  • The unit tests in test_flake8_compat.py check whether the compatibility layer works as expected

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 12, 2020
@thatch
Copy link
Contributor

thatch commented Jun 12, 2020

S201983 doesn't mean anything externally, can you include some prose about the problem it's fixing, and either point to or add a test that would catch the bug?

@josieesh
Copy link
Contributor Author

S201983 doesn't mean anything externally, can you include some prose about the problem it's fixing, and either point to or add a test that would catch the bug?

Sorry about that, still a wip pr :)

@josieesh josieesh marked this pull request as ready for review June 12, 2020 17:36
jimmylai
jimmylai approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@jimmylai jimmylai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fixit/common/flake8_compat.py
@@ -113,7 +113,9 @@ def make_checkers(self, paths: Optional[List[str]] = None) -> None:
paths[0], checks, self.options, context=self.context
)
]
self.checkers = [checker for checker in checkers if checker.should_process]
self._all_checkers = self.checkers = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add a comment and link to the Flake8 commit to be more clear.

@josieesh
Copy link
Contributor Author

Looks like a known issue with the failing tests: pypa/virtualenv#1857

@josieesh josieesh merged commit 013d3d8 into master Jun 12, 2020
@josieesh josieesh deleted the flake8_upgrade branch June 12, 2020 19:33
@josieesh josieesh mentioned this pull request Jun 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmylai jimmylai jimmylai approved these changes

@mvismonte mvismonte Awaiting requested review from mvismonte

@thatch thatch Awaiting requested review from thatch

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josieesh @thatch @jimmylai @facebook-github-bot