Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test background color on IGListCollectionView #299

Closed
rnystrom opened this issue Dec 7, 2016 · 5 comments
Closed

Unit test background color on IGListCollectionView #299

rnystrom opened this issue Dec 7, 2016 · 5 comments
Labels
bug starter-task
Milestone
2.0.0

Comments

@rnystrom
Copy link
Contributor

rnystrom commented Dec 7, 2016

We landed a couple commits to avoid changing the background to white when using storyboards or UIAppearance:

However they are only tested w/ eyeballs. We should add unit tests to prevent regressions.
@rnystrom
Copy link
Contributor Author

rnystrom commented Dec 7, 2016

@jessesquires think this needs to be part of 2.0.0? Or since 2.0.0 is stable w/ this feature we just add the tests in whenever we can get to it.

cc original authors @jeffbailey and @dcaunt

@jessesquires
Copy link
Contributor

+1 for doing tests now.

also, need to update CHANGELOG?

@jessesquires jessesquires added this to the 2.0.0 milestone Dec 7, 2016
@jeffbailey
Copy link
Contributor

I'll write the tests. I've got dinner plans tonight, but can get it done by Thursday night if that works.

@rnystrom
Copy link
Contributor Author

rnystrom commented Dec 8, 2016 •
edited
Loading

@jessesquires not sure if we should update the changelog since this fixed a feature we added in 2.0.

@jeffbailey that'd be great!

facebook-github-bot pushed a commit that referenced this issue Dec 9, 2016
@jeffbailey
Issue #299 Unit tests for IGListCollectionView
b9ede32 
Summary:
Add 2 new unit test files for IGListCollectionView.  One is for storyboards and the other for when creating the IGListCollectionView in code.

- [X] All tests pass. Demo project builds and runs.
- [X] I added tests, an experiment, or detailed why my change isn't tested.
- [X] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md)
Closes #303

Differential Revision: D4304615

Pulled By: rnystrom

fbshipit-source-id: c6edbcd493fe4ee087ce3d0aee80db484207859d
@jessesquires
Copy link
Contributor

done in b9ede32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug starter-task
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
3 participants
@rnystrom @jeffbailey @jessesquires