Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Danger] Don't warn if less than 10 loc #792

Closed
rnystrom opened this issue May 25, 2017 · 2 comments
Closed

[Danger] Don't warn if less than 10 loc #792

rnystrom opened this issue May 25, 2017 · 2 comments
Labels
enhancement PR Pending starter-task

Comments

@rnystrom
Copy link
Contributor

Need to update the Dangerfile to be less noisy for tiny changes. Will require manually scanning the PR in case it fixes a bug or something (tho a bug fix should be paired w/ a test, thus boosting the LOC count).
@BasThomas
Copy link
Contributor

What warning would you like to skip in this case?

@rnystrom
Copy link
Contributor Author

The changelog one:

https://github.com/Instagram/IGListKit/blob/master/Dangerfile#L13

@Iron-Ham Iron-Ham mentioned this issue May 25, 2017
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement PR Pending starter-task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Dangerfile to be less noisy, close #792 Instagram/IGListKit
3 participants
@rnystrom @BasThomas @Sherlouk