Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dangerfile to be less noisy, close #792 #795

Closed
wants to merge 1 commit into from
Closed

Update Dangerfile to be less noisy, close #792 #795

wants to merge 1 commit into from

Conversation

Iron-Ham
Copy link
Contributor

@Iron-Ham Iron-Ham commented May 25, 2017 •
edited
Loading

Changes in this pull request

Issue fixed: #792

Checklist

  • All tests pass. Demo project builds and runs.
  • I added tests, an experiment, or detailed why my change isn't tested.
  • I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
  • I have reviewed the contributing guide

@Iron-Ham Iron-Ham changed the title Update Dangerfile to be less noisy Update Dangerfile to be less noisy, close #792 May 25, 2017
jessesquires
jessesquires approved these changes May 25, 2017
View reviewed changes
Copy link
Contributor

@jessesquires jessesquires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@facebook-github-bot
Copy link
Contributor

@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@jessesquires jessesquires deleted the chore/dangerfile_noise branch May 25, 2017 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessesquires jessesquires jessesquires approved these changes

Assignees
No one assigned
Labels
CLA Signed ready for fb-import
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Danger] Don't warn if less than 10 loc
3 participants
@Iron-Ham @facebook-github-bot @jessesquires