Fix binding SC cell updates when the SC's section changes. #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
There was a problem hiding this comment.
@rnystrom is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Fantastic work @ccrazy88! That unit test is 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Issue fixed: #1111
As discussed in the issue's comments, this seems to be the most expedient fix if we accept that
cellForItemAtIndex:should be allowed within update blocks. I am not familiar enough withIGListAdapterto know whether this is the best solution but am willing to make any changes requested!Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.