IGListBindingSectionController no longer asserts when reloading the entire section.

CHANGELOG.md

@@ -12,6 +12,8 @@ The changelog for `IGListKit`. Also see the [releases](https://github.com/instag
 
 - Added `IGListCollectionScrollingTraits` for exposing `UICollectionView` scrolling traits to section controllers via `IGListCollectionContext`. [Adam Stern](https://github.com/adamastern) (tbd)
 
+-  `IGListBindingSectionController` no longer asserts when reloading the entire section. A warning message is now logged if the entire section is going to be reloaded. [Jeff Bailey](https://github.com/jeffbailey) (#1213)
+
 ### Fixes
 
 - Experimental fix to get the `UICollectionView` for batch updating immediately before applying the update. [Ryan Nystrom](https://github.com/rnystrom) (tbd)
@@ -236,6 +238,7 @@ ListDiff(oldArray: [], newArray: [], .equality)
 - Gracefully handle a `nil` section controller returned by an `IGListAdapterDataSource`. [Ryan Nystrom](https://github.com/rnystrom) [(#488)](https://github.com/Instagram/IGListKit/pull/488)
 
 - Fix bug where emptyView's hidden status is not updated after the number of items is changed with `insertInSectionController:atIndexes:` or related methods. [Peter Edmonston](https://github.com/edmonston) [(#395)](https://github.com/Instagram/IGListKit/pull/395)
+- Fix bug where `IGListStackedSectionController`'s children need to know `numberOrItems` before didUpdate is called. [(#348)](https://github.com/Instagram/IGListKit/pull/390)
 
 - Fix bug where `IGListStackedSectionController`'s children need to know `numberOrItems` before didUpdate is called. [(#348)](https://github.com/Instagram/IGListKit/pull/390)
 

Source/IGListBindingSectionController.m

@@ -115,9 +115,12 @@ - (void)didUpdateToObject:(id)object {
         NSArray *viewModels = [self.dataSource sectionController:self viewModelsForObject:object];
         self.viewModels = objectsWithDuplicateIdentifiersRemoved(viewModels);
     } else {
-        IGAssert([oldObject isEqualToDiffableObject:object],
-                 @"Unequal objects %@ and %@ will cause IGListBindingSectionController to reload the entire section",
-                 oldObject, object);
+#if IGLK_LOGGING_ENABLED
+        if (![oldObject isEqualToDiffableObject:object]) {
+            IGLKLog(@"Warning: Unequal objects %@ and %@ will cause IGListBindingSectionController to reload the entire section",
+                    oldObject, object);
+        }
+#endif
         [self updateAnimated:YES completion:nil];
     }
 }

Tests/Objects/IGTestDiffingObject.m

@@ -28,8 +28,18 @@ - (NSString *)description {
     return self.key;
 }
 
-- (BOOL)isEqualToDiffableObject:(id<IGListDiffable>)object {
-    return YES;
+- (BOOL)isEqualToDiffableObject:(id)object {
+    if (object == self) {
+        return YES;
+    }
+    if ([object isKindOfClass:[IGTestDiffingObject class]]) {
+        /* A simple equality test that only looks at the number of objects for the key.
+           It does not currently test the equality of each of the objects. */
+        IGTestDiffingObject *testDiffingObject = (IGTestDiffingObject *)object;
+        return self.objects.count == testDiffingObject.objects.count;
+    }
+
+    return NO;
 }
 
 @end