Replace use of method_exchangeImplementations #1583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
class_replaceMethod is significantly faster as it doesn't need to clear the entire method cache, which can be quite expensive for large apps.
|
@TimOliver has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@TimOliver merged this pull request in 3d1cad3. |
GreeMoz
pushed a commit
to appintheair/IGListKit
that referenced
this pull request
Jan 31, 2024
Summary: ## Changes in this pull request class_replaceMethod is significantly faster as it doesn't need to clear the entire method cache, which can be quite expensive for large apps. NFC, but it should be faster. No new test failures. Issue fixed: # ### Checklist - [ ] All tests pass. Demo project builds and runs. - [X] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [X] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/main/.github/CONTRIBUTING.md) Pull Request resolved: Instagram#1583 Reviewed By: fabiomassimo Differential Revision: D50013222 Pulled By: TimOliver fbshipit-source-id: 157fea52f3768b16acd09b149bd16bea4e5fdc27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
class_replaceMethod is significantly faster as it doesn't need to clear the entire method cache, which can be quite expensive for large apps.
NFC, but it should be faster. No new test failures.
Issue fixed: #
Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.