Fix TV tests #228
Closed
Fix TV tests #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessesquires
approved these changes
Nov 19, 2016
|
No slather, let's try w/out the travis dir. |
|
@rnystrom updated the pull request - view changes |
|
Hmm that didn't change anything... |
|
@rnystrom updated the pull request - view changes |
|
Changes Unknown when pulling a63fc10 on tests into * on master*. |
|
@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@rnystrom looks like coveralls is reporting again 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Saw in travis jobs that TV tests were failing. Fixed some file target memberships. Not sure why failing TV tests wouldn't fail Travis tho.
Maybe fix #227
If we don't get coverage reports I'll amend removing
cd $TAVIS_BUILD_DIRand see what happens.Pull request checklist