Use bundler to manage CocoaPods and xcpretty #57

benasher44 · 2016-10-12T13:52:14Z

Changes in this pull request

Travis appears to be using CocoaPods 1.1.0.beta.2, which is missing some fixes for Xcode 8 (see sample failing build from IGListAdapter: Fix not returning early when collectionView/dataSource is nil and completion is nil #51).
This change will ensure that a consistent CocoaPods version is used by Travis
In the added Gemfile, I picked the latest CocoaPods 1.1.0 RC (matches version in Podfile.lock) and the latest xcpretty.
Changed pod spec lint to pod lib lint to verify local files instead of files from the version specified in the spec.

Pull request checklist

All tests pass. Demo project builds and runs.
I added tests, an experiment, or detailed why my change isn't tested.
I have reviewed the contributing guide

facebook-github-bot · 2016-10-12T13:53:05Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

benasher44 · 2016-10-12T13:54:59Z

Hm. I signed the cla for #51, and it won't let me sign again.

facebook-github-bot · 2016-10-12T13:56:57Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot · 2016-10-12T14:03:00Z

@benasher44 updated the pull request - view changes

rnystrom · 2016-10-12T14:10:20Z

@benasher44 don't worry about the CLA bot, once you signed once you should be g2g from then on.

Since I'm a TravisCI noob I'm gonna ask @jessesquires to take a quick look at this.

benasher44 · 2016-10-12T14:19:47Z

Ah yep it responded shortly after. Thanks!

benasher44 · 2016-10-12T14:27:19Z

Looks like the output still contains this after moving bundle install to before_install

Could not find proper version of cocoapods (1.1.0.rc.3) in any of the sources
Run `bundle install` to install missing gems.

This build still passes, so this is mostly just annoying because pod --version will always output this. Going to try using the gemfile setting, which is also valid for objective-c projects.

facebook-github-bot · 2016-10-12T14:28:16Z

@benasher44 updated the pull request - view changes

jessesquires · 2016-10-12T16:15:01Z

this LGTM except travis is still not happy

facebook-github-bot · 2016-10-12T16:19:07Z

@benasher44 updated the pull request - view changes

jessesquires · 2016-10-12T21:08:24Z

Wow. still waiting on travis. First build has timed out.

Also:

Could not find proper version of cocoapods (1.1.0.rc.3) in any of the sources

😢

benasher44 · 2016-10-12T21:23:35Z

Yeah… I'm not sure what else to do to make that go away. It's trying to print pod --version before it runs bundle install, which seems like a Travis bug at this point (literally does it on the next line). It knows there's a Gemfile, so it really shouldn't try to print info about gems before they're installed. Maybe it doesn't expect that we're going to install a different version of the CocoaPods gem? In any case, printing versions of things before the install or before_install phases seems like a Travis bug. Filed travis-ci/travis-ci#6717.

As for the timeout, it looks like it's timing out during code signing. Code signing probably isn't needed here, since we just want to verify that it builds and tests pass. I'm going to try disabling that. I've tried this with travis before the Xcode 8 GM was released, and it caused issues. Maybe it's fixed now?

benasher44 · 2016-10-12T21:24:24Z

Luckily, even though that message is in red, it doesn't fail the build. Here's a passing one: https://travis-ci.org/Instagram/IGListKit/jobs/167060407

rnystrom · 2016-10-13T01:52:17Z

Nice, I wonder if we can make any subscription updates to Travis to get higher pri queues...

@jessesquires think we're g2g here?

benasher44 · 2016-10-13T01:55:29Z

Are the timeouts a new issue in this PR or existing?

benasher44 · 2016-10-13T02:09:58Z

Ah looks like existing: https://travis-ci.org/Instagram/IGListKit/builds/167080863. This is good to go in terms of fixing pod spec lint flakes.

Quick question though. I just realized this is doing pod spec lint instead of pod lib lint. The former will go fully based on the spec (including pulling the spec's tag from git), whereas the latter always uses the files in the working directory. The latter seems like it be more useful for CI, since it'll verify new changes, whereas the former will always check the current version in the podspec. Should I change this?

facebook-github-bot · 2016-10-13T13:13:42Z

@benasher44 updated the pull request - view changes

benasher44 · 2016-10-13T13:14:09Z

Tried locally disabling code signing with CODE_SIGNING_ALLOWED=NO, and the tests failed to bootstrap every time. CODE_SIGNING_REQUIRED=NO seemed to work though, and it appeared to skip the signing step for tests. So maybe less hanging now?

facebook-github-bot · 2016-10-13T13:53:56Z

@benasher44 updated the pull request - view changes

benasher44 · 2016-10-13T13:54:20Z

Despite CODE_SIGNING_REQUIRED changes, there is still plenty of code signing happening. 🔥

This might be a red herring anyway, since the thing that happens right after code signing is starting the tests. It might just be hanging waiting for the simulator.

Anyway, I think I'm out of things I want to try in this PR.

jessesquires · 2016-10-13T17:56:43Z

Anyway, I think I'm out of things I want to try in this PR.

😆 Thanks for all the help so far @benasher44 ! 🙌

I've been fighting with travis-ci timeouts since the upgrade to Xcode8. No idea whats going on, but all of my builds for other projects timeout for every single iOS 8 build. /shrug

jessesquires · 2016-10-13T17:58:20Z

😕
https://twitter.com/travisci/status/783389212825489408

benasher44 · 2016-10-13T18:01:01Z

No prob! There are a few tickets floating around about Xcode 8 Travis things, but I hadn't seen a response yet. So, good to see a response from Travis!

benasher44 · 2016-10-13T18:03:21Z

Early on, I found that only the iPhone SE destination worked reliably on Travis. This may or may not still be the case. It might be worth adding that one in or replacing one of the existing destinations, so that if that or another seems consistent, at least you have one simulator that always works to keep PRs going.

benasher44 · 2016-10-13T18:18:54Z

There's still the unanswered question of pod spec lint vs pod lib lint. I could make this small change here as well (sort of related because ruby/CocoaPods?). I could also just file an issue for someone to dig into later.

Checks local files instead of the version in the spec

facebook-github-bot · 2016-10-13T19:48:27Z

@benasher44 updated the pull request - view changes

benasher44 · 2016-10-13T19:48:36Z

Ah thought previous comment had a thumbs up, but it was the one before that. Let me know, and I'll revert.

jessesquires · 2016-10-14T00:09:13Z

Sounds good to me! 👍

rnystrom · 2016-10-14T00:47:09Z

Sweet, I think we're g2g here. We can resolve Travis infra timeout issues down the road if they come up.

facebook-github-bot · 2016-10-14T00:47:36Z

Thanks for importing. If you are a Facebook employee, you can view this diff on Phabricator.

benasher44 · 2016-10-14T01:35:00Z

Yup! I agree.

Summary: - Travis appears to be using CocoaPods 1.1.0.beta.2, which is missing some fixes for Xcode 8 (see [sample failing build](https://travis-ci.org/Instagram/IGListKit/jobs/166935850) from Instagram#51). - This change will ensure that a consistent CocoaPods version is used by Travis - In the added Gemfile, I picked the latest CocoaPods 1.1.0 RC (matches version in Podfile.lock) and the latest xcpretty. - Changed `pod spec lint` to `pod lib lint` to verify local files instead of files from the version specified in the spec. - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes Instagram#57 Differential Revision: D4019655 Pulled By: rnystrom fbshipit-source-id: 422e55c44dfdf276b587ea6e12ae30218a237ff5

Use bundler to manage CocoaPods and xcpretty

bd26b25

benasher44 mentioned this pull request Oct 12, 2016

IGListAdapter: Fix not returning early when collectionView/dataSource is nil and completion is nil #51

Closed

3 tasks