Drop section moves if they are also deleted or inserted #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rnystrom updated the pull request - view changes |
| @@ -77,9 +77,10 @@ - (instancetype)initWithInsertSections:(NSIndexSet *)insertSections | |||
| const NSInteger from = move.from; | |||
| const NSInteger to = move.to; | |||
|
|
|||
| // if the move is already deleted or inserted, discard it and use delete+insert instead | |||
| // if the move is already deleted or inserted, discard it because count-changing operations must match | |||
| // with data source changesw | |||
added 2 commits
March 23, 2017 11:53
|
@rnystrom updated the pull request - view changes |
|
@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Issue fixed: #430
Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.