Make Section Controllers Generic on ObjectType #625
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 7, 2017 13:50
…ionController on ViewModel
|
@Adlai-Holler updated the pull request - view changes |
|
@Adlai-Holler -- yep, known issue. (fixed in #631) the project file got messed up from a bad merge |
|
@Adlai-Holler - just landed fixes. mind rebasing? |
|
Well, this thing is dead-on-arrival. As of Swift 3, you can't use a Anyway, that's the case for now. Too bad so sad. |
|
@Adlai-Holler take a look at this, been kicking it around for a while, I think this could be really great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Issue fixed: #622
@jessesquires I can't open the iOS examples project on my machine. Xcode 8.3 complains that the project is unreadable. So I believe I updated the example projects to be compatible but I'm not 100% sure.