Added CHANGELOG entry for #51 #67
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
|
||
| * Fixed `-[IGListAdapter reloadDataWithCompletion:]` not returning early when `collectionView` or `dataSource` is nil and `completion` is nil. | ||
| [Ben Asher](https://github.com/benasher44) | ||
| [#51](https://github.com/Instagram/IGListKit/pull/51) |
There was a problem hiding this comment.
- Let's use
-for lists - I think we probably should title this
## 2.0.0? (or1.1.0) - Can we shrink it all to a single line?
ala https://github.com/jessesquires/JSQMessagesViewController/blob/develop/CHANGELOG.md#fixes
There was a problem hiding this comment.
I only left it as master, so that you all could change it when you all are ready to do the release. Happy to change it though if you all have a new version picked out already.
There was a problem hiding this comment.
A few other advantages to keeping a master section if you all are still discussing:
- PRs can continue to flow in and include CHANGELOG entries, and it's clear where those entries go.
- It's clear to readers what in the CHANGELOG is released and what is coming soon.
|
@benasher44 updated the pull request - view changes |
|
This looks good to me. Whether we do |
|
@benasher44 thanks! Sounds good we will keep it "Master" for now and update when we settle on versions |
|
Thanks for importing. If you are a Facebook employee, you can view this diff on Phabricator. |
Changes in this pull request
Fixed #63. I used the style we use in CocoaPods, but I'm happy to adjust!
Pull request checklist