Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/beginners warning #812

Closed
wants to merge 4 commits into from

Conversation

weyert
Copy link
Contributor

@weyert weyert commented Jun 20, 2017

Changes in this pull request

Issue fixed: #811

I don't think this change needs a item in CHANGELOG.md as it's not a real bug fix or enhancement that influences the behaviour of the library.

Checklist

  • All tests pass. Demo project builds and runs.
  • I added tests, an experiment, or detailed why my change isn't tested.
  • I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
  • I have reviewed the contributing guide

weyert and others added 4 commits January 5, 2017 21:28
Copy link
Contributor

@jessesquires jessesquires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 💯

@facebook-github-bot
Copy link
Contributor

@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@weyert
Copy link
Contributor Author

weyert commented Jun 20, 2017

Great thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding a warning for beginners
3 participants