Improved the documentation #820
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@weyert updated the pull request - view changes |
Source/IGListAdapter.m
Outdated
| @@ -272,6 +272,7 @@ - (void)performUpdatesAnimated:(BOOL)animated completion:(IGListUpdaterCompletio | |||
| id<IGListAdapterDataSource> dataSource = self.dataSource; | |||
| UICollectionView *collectionView = self.collectionView; | |||
| if (dataSource == nil || collectionView == nil) { | |||
| IGLKLog(@"Warning: Your call to performUpdatesAnimated-method is ignored as dataSource or collectionView haven't been set."); | |||
There was a problem hiding this comment.
instead of "performUpdatesAnimated-method" we can use %s and pass __PRETTY_FUNCTION__ 😄
Source/IGListAdapter.m
Outdated
| @@ -308,6 +309,7 @@ - (void)reloadDataWithCompletion:(nullable IGListUpdaterCompletion)completion { | |||
| id<IGListAdapterDataSource> dataSource = self.dataSource; | |||
| UICollectionView *collectionView = self.collectionView; | |||
| if (dataSource == nil || collectionView == nil) { | |||
| IGLKLog(@"Warning: Your call to reloadDataWithCompletion-method is ignored as dataSource or collectionView haven't been set."); | |||
|
@weyert updated the pull request - view changes |
|
thanks @weyert ! just a few comments 😄 |
rnystrom
suggested changes
Jun 22, 2017
|
Thank you, I will make the changes :) |
Fixed the issue with the failed merge of `upstream`
|
@weyert updated the pull request - view changes |
|
@jessesquires @rnystrom made the change as requested 👍 |
|
@weyert updated the pull request - view changes |
|
@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the documentation so it that the Getting Started guide calls out that you need to set
dataSource-property of theIGListAdapteras I totally misse that.