Check webhooks slice length before calling xorm (go-gitea#20642)

xorm.db.Insert errors for empty slices. Fixes: go-gitea#20641 Co-authored-by: Lauris BH <[email protected]> Co-authored-by: John Olheiser <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
IntegraSDL · Aug 10, 2022 · 94e79ac · 94e79ac
1 parent cf0fca3
commit 94e79ac
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/models/webhook/webhook.go b/models/webhook/webhook.go
@@ -399,6 +399,10 @@ func CreateWebhook(ctx context.Context, w *Webhook) error {
 
 // CreateWebhooks creates multiple web hooks
 func CreateWebhooks(ctx context.Context, ws []*Webhook) error {
+	// xorm returns err "no element on slice when insert" for empty slices.
+	if len(ws) == 0 {
+		return nil
+	}
 	for i := 0; i < len(ws); i++ {
 		ws[i].Type = strings.TrimSpace(ws[i].Type)
 	}