This repository has been archived by the owner on May 17, 2023. It is now read-only.
18.4.2 #1164
Closed
18.4.2 #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Enable setting MaFrameSize for SWBRC -CheckVideoParamQueryLile() should not set default values -Move all check to the function - CheckMaxFrameSize()
dvrogozh
requested review from
akokoshn,
alariono,
artem-shaporenko,
dmitrybrazhkin,
dmitryermilov,
eistarov,
onabiull,
oakasatkina,
stasefremov,
takulako,
varistar and
a team
as code owners
Fixes: Intel-Media-SDK#1165 cmake option() rewrites set() without FORCE flag which we tried to use to instuct gtest to avoid installation path. Signed-off-by: Dmitry Rogozhkin <[email protected]>
lakulako
reviewed
Feb 8, 2019
| SaveParams(par); | ||
| // int the case of MaxSliceSize BRC works in VBR mode (instead LA) | ||
| par.mfx.RateControlMethod = MFX_RATECONTROL_VBR; | ||
| par.mfx.MaxKbps = par.mfx.TargetKbps * 2; |
There was a problem hiding this comment.
VBR is define with single bitrate. Now it is based on mfx.MaxKbps. Better use par.mfx.MaxKbps = par.mfx.TargetKbps
added 4 commits
February 11, 2019 23:02
-Fix wrong condition for supported rate controls Fixes: 99743da ("h264e: Rework check MaxFrameSize")
-LowDelayBRC not need setting MaxFrameSize: if MaxFrameSize not specified Query() should returns ERR_NONE Init() should set MaxFrameSize = AVG frame size
-Replace GetExtBuffer() by GetExtBufferRef for avoid possible dereferencing nullptr
-AdaptiveMaxFrameSize can't be ON if MaxFrameSizeP = 0 or LowPower is ON
|
@onabiull : PR updated. |
onabiull
approved these changes
Mar 5, 2019
|
@azhogov : why CI trigger failed? |
This just made build possible. Functionality not tested.. Partially addresses Intel-Media-SDK#1195
|
@dvrogozh: It is fixed now. Need to update failed PRs. |
Fix for Intel-Media-SDK#1165 This patch keeps gtest google tests in-house avoiding their installation. The idea is that user will run 'make test' or 'ctest' or execute tests directly from the build tree rather than under installed environment. These tests are intended to make sure that mediasdk behaves correctly before install. Signed-off-by: Dmitry Rogozhkin <[email protected]>
We might have gtests elsewhere in the project, not only in tests directory. Let's enable tests separately before including any source directories. Signed-off-by: Dmitry Rogozhkin <[email protected]>
Fixes: Intel-Media-SDK#1165 We may face situaiton that system has installed gtest/gmock which will be incompatible with the version against which we linked our tests. Hence, force using our own built gtest, gmock. Signed-off-by: Dmitry Rogozhkin <[email protected]>
Fixes: Intel-Media-SDK#1285 This change allows builds against system installed gtest if cmake -DUSE_SYSTEM_GTEST=ON is specified. Mind that this change does not provide any configure level check over gtest. And it does not provide proper target configuration if gtest is installed to custom location. Build will work if gtest will happen to be in the right place at the right time. Signed-off-by: Dmitry Rogozhkin <[email protected]>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
18.4.2 scope.