-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor complex comparison functions #1320
Conversation
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1320/index.html |
Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_79 ran successfully. |
81b1808
to
c85e02e
Compare
Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_79 ran successfully. |
c85e02e
to
0ee44af
Compare
Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_2 ran successfully. |
3d2e463
to
8694923
Compare
Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_3 ran successfully. |
1 similar comment
Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_3 ran successfully. |
8694923
to
88c59bc
Compare
Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_36 ran successfully. |
For some reason changes a causing a new failure in array API test suite:
This failure is not present in the main branch. |
I saw this too. It's in linspace. It doesn't seem to be related to this PR, but worth looking at. |
Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_36 ran successfully. |
Yes, the "test_creation_functions.py" failure is sporadic, I just reran the workflow steps and this particular test passed. |
I just reproduced the failure locally:
with the underlying cause being the following failure in "_copy_from_numpy_into(dst, np_ary)":
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_33 ran successfully. |
This PR refactors complex comparison functions into a new header file,
utils\math_utils.hpp
.