Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor complex comparison functions #1320

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Aug 2, 2023

This PR refactors complex comparison functions into a new header file, utils\math_utils.hpp.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

@coveralls
Copy link
Collaborator

coveralls commented Aug 2, 2023

Coverage Status

coverage: 84.923%. remained the same when pulling 88c59bc on refactor-complex-comparisons into b055ff9 on master.

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_79 ran successfully.
Passed: 612
Failed: 388
Skipped: 119

@ndgrigorian ndgrigorian force-pushed the refactor-complex-comparisons branch from 81b1808 to c85e02e Compare August 2, 2023 17:39
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_79 ran successfully.
Passed: 611
Failed: 389
Skipped: 119

@ndgrigorian ndgrigorian force-pushed the refactor-complex-comparisons branch from c85e02e to 0ee44af Compare August 9, 2023 02:24
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_2 ran successfully.
Passed: 639
Failed: 361
Skipped: 119

@ndgrigorian ndgrigorian force-pushed the refactor-complex-comparisons branch 2 times, most recently from 3d2e463 to 8694923 Compare August 9, 2023 03:48
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_3 ran successfully.
Passed: 639
Failed: 361
Skipped: 119

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_3 ran successfully.
Passed: 639
Failed: 361
Skipped: 119

@ndgrigorian ndgrigorian force-pushed the refactor-complex-comparisons branch from 8694923 to 88c59bc Compare August 10, 2023 06:38
@ndgrigorian ndgrigorian marked this pull request as ready for review August 10, 2023 06:40
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_36 ran successfully.
Passed: 912
Failed: 88
Skipped: 119

@oleksandr-pavlyk
Copy link
Collaborator

For some reason changes a causing a new failure in array API test suite:

array_api_tests/test_creation_functions.py ........F..... [ 3%]

This failure is not present in the main branch.

@ndgrigorian
Copy link
Collaborator Author

For some reason changes a causing a new failure in array API test suite:

array_api_tests/test_creation_functions.py ........F..... [ 3%]

This failure is not present in the main branch.

I saw this too. It's in linspace. It doesn't seem to be related to this PR, but worth looking at.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_36 ran successfully.
Passed: 913
Failed: 87
Skipped: 119

@oleksandr-pavlyk
Copy link
Collaborator

Yes, the "test_creation_functions.py" failure is sporadic, I just reran the workflow steps and this particular test passed.

@oleksandr-pavlyk
Copy link
Collaborator

I just reproduced the failure locally:

E           hypothesis.errors.Flaky: Hypothesis test_linspace(num=3866, dtype=dtype('float32'), endpoint=False, data=data(...)) produces unreliable results: Falsified on the first call but did not on a subsequent one
E           Falsifying example: test_linspace(
E               num=3866,
E               dtype=dtype('float32'),
E               endpoint=False,
E               data=data(...),
E           )
E           Draw 1 (start): 9.999999747378752e-06
E           Draw 2 (stop): -2.220446049250313e-16
E           Draw 3 (kw): {'dtype': dtype('float32'), 'endpoint': False}
E           Failed to reproduce exception. Expected:
E           >   ???

with the underlying cause being the following failure in "_copy_from_numpy_into(dst, np_ary)":

E           >       ti._copy_numpy_ndarray_into_usm_ndarray(
E                       src=src_ary, dst=dst, sycl_queue=copy_q
E                   )
E           E       RuntimeError: Native API failed. Native API returns: -30 (PI_ERROR_INVALID_VALUE) -30 (PI_ERROR_INVALID_VALUE)

@ndgrigorian ndgrigorian merged commit 597cd4b into master Aug 10, 2023
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_33 ran successfully.
Passed: 913
Failed: 87
Skipped: 119

@ndgrigorian ndgrigorian deleted the refactor-complex-comparisons branch August 14, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants