Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some array api test cases #1328

Merged
merged 5 commits into from
Aug 8, 2023

Conversation

ndgrigorian
Copy link
Collaborator

This PR fixes an array API test case for logaddexp that fails for mixed nan and number operands.

It also applies a previous fix used for astype with order="K" to copy.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_111 ran successfully.
Passed: 911
Failed: 89
Skipped: 119

@ndgrigorian ndgrigorian force-pushed the fix-some-array-api-test-cases branch from a202d13 to 1b5419f Compare August 7, 2023 17:39
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_112 ran successfully.
Passed: 912
Failed: 88
Skipped: 119

ndgrigorian and others added 2 commits August 7, 2023 15:19
- 'or' conditions can sometimes cause wrong results when using the OS compiler
If both arguments are -inf, the result is also -inf.
@ndgrigorian ndgrigorian marked this pull request as ready for review August 8, 2023 00:21
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_113 ran successfully.
Passed: 912
Failed: 88
Skipped: 119

@oleksandr-pavlyk
Copy link
Collaborator

oleksandr-pavlyk commented Aug 8, 2023

I have pushed a change to factor scalar implementation out and fixed it to ensure logaddexp(-inf,-inf)=-inf.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_114 ran successfully.
Passed: 912
Failed: 88
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk merged commit df8eb5f into enable-operators Aug 8, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-some-array-api-test-cases branch August 8, 2023 10:13
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants