-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SyclPlatform equality testing and hashing implemented #1333
Conversation
Added declaration, doxygen docs, implementation and tests.
Also enabled overlooked check_default_context
59979c6
to
b40d357
Compare
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1333/index.html |
Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_37 ran successfully. |
1 similar comment
Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_37 ran successfully. |
It is not yet supported on Windows.
Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_38 ran successfully. |
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_40 ran successfully. |
While testing
dpctl
in the flat device hierarchy mode I realized we have not implemented equality testing fordpctl.SyclPlatform
which caused testtest_sycl_context.py::test_multi_device_different_platforms
to fail.This PR implements
DPCTLPlatform_AreEq
,DPCTLPlatform_Hash
, adds tests and implamentsdpctl.SyclPlatform.__equal__
anddpctl.SyclPlatform.__hash__
based on these.Incidentally this PR also corrects declaration of
DPCTLContext_Hash
which mistakenly used__dpctl_take
instead of__dpctl_keep
annotation.