-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nonzero result dtype win #1336
Conversation
This returns default index type for give device. Since all devices are 64-bit devices, it always returns "i8".
Closes gh-1335. The issue was caused by nonzero using default integral data type, not default index data type.
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1336/index.html |
Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_38 ran successfully. |
Verified:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
thanks @oleksandr-pavlyk
The array API test failure "array_api_tests/test_special_cases.py:1240: " is marked as flaky by hypothesis, and responsible for passing tests being one fewer than in the main branch. Ready to merge. |
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_44 ran successfully. |
This PR closes gh-1335.
It introduced array API notion of (device-specific) default index data type, and ensure that
dpctl.tensor.nonzero
output arrays are created of this data type.
Relevant test was adjusted accordingly.