Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes redundant reduction files #1480

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

ndgrigorian
Copy link
Collaborator

This pull request removes two files made redundant when reductions were split out of _tensor_impl, namely, dpctl/tensor/libtensor/source/reduction_over_axis.cpp and dpctl/tensor/libtensor/source/reduction_over_axis.hpp

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

github-actions bot commented Dec 1, 2023

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 85.979%. remained the same
when pulling 4060e1a on remove-unnecessary-reduction-files
into b3ba5ac on master.

Copy link

github-actions bot commented Dec 1, 2023

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_19 ran successfully.
Passed: 874
Failed: 57
Skipped: 59

Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ndgrigorian !

@ndgrigorian ndgrigorian merged commit 07dea79 into master Dec 4, 2023
@ndgrigorian ndgrigorian deleted the remove-unnecessary-reduction-files branch December 22, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants