-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced few TypeError with ValueError in _elementwise_common #1496
Replaced few TypeError with ValueError in _elementwise_common #1496
Conversation
Used ValueError instead of TypeError per Python guidelines. Inappriate uses were pointed out by @vtavana
This change was prompted per discussion in #1490 |
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1496/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @oleksandr-pavlyk!
Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_7 ran successfully. |
9d172b7
to
a2ec2f2
Compare
Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_8 ran successfully. |
Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_9 ran successfully. |
Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_9 ran successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests now pass so LGTM! Thanks for this clean up @oleksandr-pavlyk
Other incorrect TypeErrors seem to exist in the project but those can be addressed in separate PRs.
Used
ValueError
instead ofTypeError
per Python guidelines.Inappropriate uses were pointed out by @vtavana (Thank you)