Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generate-docs workflow breakage when run on PR closure #1502

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Fix generate-docs workflow breakage when run on PR closure #1502

merged 1 commit into from
Jan 24, 2024

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Fix for generate documentation workflow. Only run "Publish docs" step if PR is not being closed.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions GitHub Actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1502/index.html

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 90.684%. remained the same
when pulling f35f2d0 on fix-gen-docs
into 12cd523 on master.

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_25 ran successfully.
Passed: 908
Failed: 1
Skipped: 86

ndgrigorian
ndgrigorian approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this will fix the problem

@oleksandr-pavlyk oleksandr-pavlyk merged commit 5fca9e2 into master Jan 24, 2024
27 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-gen-docs branch January 24, 2024 18:07
@github-actions GitHub Actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Jan 26, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @ndgrigorian