Decouple pybind11 and kernels #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change affected linspace, arange, and full constructors. This change causes no user visible changes.
Removed uses of `#include <pybind11/pybind11.h>` from header files in libtensor/include/kernels folder Replaced `#include <CL/sycl.hpp>` with `#include <sycl/sycl.hpp>`. Introduced "kernels/dpctl_tensor_types.hpp" which defines the type, and included it in header files. Added static_assert in some CPP files to ensure that `py::ssize_t` is the same as `dpctl::tensor::ssize_t`.
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_51 ran successfully. |
|
@oleksandr-pavlyk |
|
I deliberately left Files in the kernel subfolder do not, so I think we should leave |
Since utils headers are used in kernels, to make kernels/ independent of pybind11, it is necessary to ensure that all depedent header files also do not include pybind11. Changed offset_utils to use dpctl::tensor::ssize_t instead of py::ssize_t. Factored out pybind11 independent components of type_dispatch.hpp header into type_dispatch_building.hpp . What remains uses dpctl4pybind11 and hence genuinely depends on pybind11.
ndgrigorian
reviewed
Jan 31, 2024
|
Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_52 ran successfully. |
ndgrigorian
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved all uses of pybind11 types and functions out of
libtensor/include/kernels.py::objectand casters were moved to respective*.cppfiles.dpctl::tensor::ssize_twas definedpy::ssize_tin function signatures replaced with of library'sssize_ttype#include "pybind11/pybind11.h"removed (speeding up compilation time)static_assert(std::is_same_v(py::ssize_t, dpctl::tensor:;ssize_t>)in aome*.cppfiles#include <CL/sycl.hpp>has been replaced with#include <sycl/sycl.hpp>.