Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docstring description of axis keyword in cumulative functions #1669

Merged
merged 1 commit into from
May 10, 2024

Conversation

antonwolfy
Copy link
Collaborator

@antonwolfy antonwolfy commented May 10, 2024

The axis keyword in cumulative functions supported only as an integer. No support of a axis with tuple value is assumed.
The PR proposes to update the docstrings description to reflect the actual behavior.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@antonwolfy antonwolfy self-assigned this May 10, 2024
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @antonwolfy !

Copy link

github-actions bot commented May 10, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.892%. remained the same
when pulling 05426b5 on update-axis-docstring-in-accumulate-functions
into 1243edc on master.

Copy link

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_333 ran successfully.
Passed: 883
Failed: 9
Skipped: 92

@antonwolfy antonwolfy merged commit d3e124a into master May 10, 2024
60 checks passed
@antonwolfy antonwolfy deleted the update-axis-docstring-in-accumulate-functions branch May 10, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants